Skip to content

Adding 2025-03-01-preview api version #33924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bsomeshekar
Copy link
Member

@bsomeshekar bsomeshekar commented Apr 14, 2025

Current architecture: The address data for a Site resource is currently stored in a separate Microsoft.EdgeOrder/Address resource and the armId reference is stored in Site object. This introduces two main concerns:
1.Resource Management Complexity: Storing addresses in a separate resource adds overhead in managing resources within the Azure portal.
2.Regional Constraints: Some customers face regional restrictions when creating resources, which increases operational costs for supporting address resources across multiple regions.
Proposed Solution:
After review, it has been decided to store address data directly within the Site resource, eliminating the need for a separate Address resource. The address field will remain optional to ensure continued support for existing sites that do not have address data.

For existing customers, address migration will be RP-initiated. The HK task within RP will retrieve all site resources using the old API version, fetch the associated AEHC address data for each site, and then make a PUT call with the new API version to update the address field within the Site resource.

Along with the above, adding changes for labels/tags and tenant level routing for service group based sites support.

Changes are already merged to private repo based on ARM review, below are the PRs for reference:
https://github.com/Azure/azure-rest-api-specs-pr/pull/20695
https://github.com/Azure/azure-rest-api-specs-pr/pull/21400
https://github.com/Azure/azure-rest-api-specs-pr/pull/21593

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

openapi-pipeline-app bot commented Apr 14, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Apr 14, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

Copy link

github-actions bot commented Apr 14, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Edge-edge
TypeSpec Microsoft.Edge
Go sdk/resourcemanager/commonedgesitemanageroperations/armcommonedgesitemanageroperations
Go sdk/resourcemanager/sitemanager/armsitemanager

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 14, 2025
@github-actions github-actions bot added ARMAutoSignedOff ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Apr 30, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 30, 2025
@bsomeshekar
Copy link
Member Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 33924 in repo Azure/azure-rest-api-specs

@tadelesh
Copy link
Member

tadelesh commented May 6, 2025

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@msyyc
Copy link
Member

msyyc commented May 6, 2025

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@tadelesh
Copy link
Member

tadelesh commented May 6, 2025

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@premparekh premparekh closed this May 7, 2025
@premparekh premparekh reopened this May 7, 2025
@premparekh premparekh enabled auto-merge (squash) May 7, 2025 03:58
@premparekh premparekh merged commit 8cad625 into Azure:main May 7, 2025
50 of 61 checks passed
koen-mertens pushed a commit to koen-mertens/azure-rest-api-specs that referenced this pull request May 7, 2025
* Adding 2025-03-01-preview api version

* Fixing format

* Fixing validation errors

* Fixing format

* Adding versioning

* Suppressing lintdiff errors

* Removing sdk generation config from readme

* Adding output-dir to tsp files

* Adding where clause for suppression rules

* Incorporating review comments

* Correcting format

* Updating suppression where clause

* Refactoring to fix lintdiff

* Correcting typo to fix lintdiff

---------

Co-authored-by: Yuchao Yan <[email protected]>
johnkoh-msft pushed a commit to johnkoh-msft/azure-rest-api-specs that referenced this pull request May 8, 2025
* Adding 2025-03-01-preview api version

* Fixing format

* Fixing validation errors

* Fixing format

* Adding versioning

* Suppressing lintdiff errors

* Removing sdk generation config from readme

* Adding output-dir to tsp files

* Adding where clause for suppression rules

* Incorporating review comments

* Correcting format

* Updating suppression where clause

* Refactoring to fix lintdiff

* Correcting typo to fix lintdiff

---------

Co-authored-by: Yuchao Yan <[email protected]>
johnkoh-msft added a commit that referenced this pull request May 12, 2025
…04 11 preview (#34389)

* Copy files from preview/2025-03-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-04-11-preview

Updated the API version from preview/2025-03-01-preview to preview/2025-04-11-preview.

* Added tag for 2025-04-11-preview in readme file

* Fix namespace

* Fix validation errors

* Fix validation errors again

* Change type of body schema

* Fix example

* Updated the apiFlowOptions field

* Add None

* Remove None

* Add ForceDisable Pipeline enum

* Add PipelineForceDisabled status

* Bump @azure-tools/typespec-client-generator-cli (#34410)

Bumps the typespec-client-generator-cli group with 1 update in the / directory: [@azure-tools/typespec-client-generator-cli](https://github.com/Azure/azure-sdk-tools).


Updates `@azure-tools/typespec-client-generator-cli` from 0.20.0 to 0.21.0
- [Release notes](https://github.com/Azure/azure-sdk-tools/releases)
- [Commits](https://github.com/Azure/azure-sdk-tools/commits)

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-cli"
  dependency-version: 0.21.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typespec-client-generator-cli
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* adding options for csharp generator (#34413)

Co-authored-by: deepakmaurya_microsoft <[email protected]>

* Add new APC API version (#33625)

* Add new version
* Typespec v1.0.0 and add .NET SDK generation options

* Adding options for C# generator for MongoDB.Atlas (#34415)

* adding options for c# generator

* updating tspconfig.yaml

* Bump vite from 6.3.3 to 6.3.4 in /.github (#34412)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.3.3 to 6.3.4.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v6.3.4/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 6.3.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Sync eng/common directory with azure-sdk-tools for PR 10523 (#34418)

* fix: bump node version in emitter pipeline

* pr feedback

---------

Co-authored-by: Jorge Rangel <[email protected]>
Co-authored-by: Jorge Rangel <[email protected]>

* [LintDiff] Improve logging output (#34398)

* Improve logging output

* Adjust logging

* Trivial change to trigger LintDiff

* Breaking change that causes LintDiff to fail

* Always include link in the log

* Try to break URL

* generate autorest exception

* Add source to table

* Contrive an error that will fail LintDiff

* Regular LintDiff failure

* Contrive autorest error

* Log violations

* -table

* Logging inside lint-diff.ts instead of lintdiff.yaml

* +list

* log GITHUB_SERVER_URL

* log more

* console.log

* Revert contosowidgetmanager

* Exit if there's nothing to do

* Test successful LintDiff run

* Revert "Test successful LintDiff run"

This reverts commit 6d7bd0a.

* Log link to workflow summary on success, too

* Reverted apiview enablement due to a bug (#34417)

* [shared] Add SpecModel (#33362)

- Fixes #33227

* [spec-model] One file per class, add tests for 100% coverage (#34431)

* [spec-model] Remove sync access check from ctors (#34432)

- Improves perf and testability

* [spec-model] Move specModel to options (#34433)

- Only needed for relative paths in toJsonAsync()

* Add None

* Remove None

* Add ForceDisable Pipeline enum

* [LintDiff, Avocado] Extract label-override code (#34445)

* Generalize avocado-status.js, wire up lintdiff-status.yaml

* Testing, lintdiff.yaml -> lintdiff-code.yaml

* Now with types

* prettier

* Use reusable workflow

* Param names, copy

* Revert label.js changes, they're not needed in this PR

* Set Status

* Prettier

* CQA build api changes (#34299)

* CQA build api changes

* adding swagger references in readme

* Adding initial examples for the new api version

* adding examples for new changes

* fixing build failures

* updating tsp examples

* whitespace error

* Spell checks

---------

Co-authored-by: Yash Oswal <[email protected]>
Co-authored-by: Bidisha Chakraborty <[email protected]>

* Update client settings for releasing Workload .Net SDK (#34461)

* [recoveryservicesdatareplication] update tsp config (#34360)

* Update client.tsp

* format

* remove the duplicate models for projects, branches, database, roles a… (#34283)

* remove the duplicate models for projects, branches, database, roles and endpoints in the main.tsp

* updated examples using oav generate examples command

* updated the examples to fix the model and semantic validations

* fix typespec errors

* addressed comments changed the namespace to neon.postgres

* fix typespec issue

* update the spec by removing the unused api

* updated the typespec by removing the out of scope items

---------

Co-authored-by: Srinivas Alluri <[email protected]>

* Add package to validate TypeSpec migration result (#34438)

* Add package to validate typespec migration

* Some fix

* Add prompt support

* update

* Update

---------

Co-authored-by: Pan Shao <[email protected]>
Co-authored-by: Mike Harder <[email protected]>

* Sync eng/common directory with azure-sdk-tools for PR 10534 (#34455)

* Add helper function for spec-gen-sdk pipeline

* Move logging script sourceing to global scope

---------

Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>

* Add spilloverDeploymentName (#34376)

* Sync eng/common directory with azure-sdk-tools for PR 10542 (#34454)

* update most current taxnonomy for entra

* update link

---------

Co-authored-by: Minh Anh <[email protected]>

* Add Relationships RP Public Preview Spec Files (#33932)

* add initial Relationships RP files

* make provisioningState readOnly

* update readme, remove readmes and edit confiig

* [spec-model] Add option to create Readme from string content (#34465)

* Fix two bugs for grounding api and acl (#34422)

* [eng/tools] Upgrade target and module to match TypeSpec repo (#34480)

- Required to use APIs like string.replaceAll()

* ACR: Update 2025-04-01 GA Swagger to fix SDK generation failure (#34233)

* ACR: Update 2025-04-01 GA Swagger to fix SDK generation failure

* add lintdiff suppression for connected registry update parameters

* fix suppression parameter reference

* address review comments

* deploy the proxy with human-readable multipart output (#34409)

Co-authored-by: Scott Beddall <[email protected]>

* [dellstorage] update-tspconfig (#34459)

* update-tspconfig

* Update tspconfig.yaml

* java config

* update config

---------

Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: XiaofeiCao <[email protected]>
Co-authored-by: jliusan <[email protected]>

* java, mgmt, Azure Chaos Studios, client (#34466)

* fist, mgmt, client.tsp, add flattenProperty for backward-compatibility (#34204)

* Adding 2025-03-01-preview api version (#33924)

* Adding 2025-03-01-preview api version

* Fixing format

* Fixing validation errors

* Fixing format

* Adding versioning

* Suppressing lintdiff errors

* Removing sdk generation config from readme

* Adding output-dir to tsp files

* Adding where clause for suppression rules

* Incorporating review comments

* Correcting format

* Updating suppression where clause

* Refactoring to fix lintdiff

* Correcting typo to fix lintdiff

---------

Co-authored-by: Yuchao Yan <[email protected]>

* fix go config (#34487)

* java, mgmt, chaos, update client.tsp (#34488)

* add go config (#34485)

* Retirement announcement (#34353)

Co-authored-by: Faraz Siddiqui <[email protected]>

* [LintDiff] Use spec model (#34463)

* Tell typescript to use ESNext to eliminate errors on private class members

* Use spec model

* Update package-lock.json

* Contrive a change to test LintDiff

* Remove deep-eql, use bundle and JSON.stringify instead, add test coverage

* Use deref

* Remove fs mock

* Revert change that triggers LintDiff

* Remove ESNext from .github/shared/tsconfig.json

* Remove target/module definitoins from lint-diff/tsconfig.json

* newlines

* newline

* Update watchers to watch new workflow names (#34501)

* Upgrade typespec 1.0 (#34482)

* [LintDiff] Only process existing files (#34504)

* Only process existing files

* Add test coverage

* Skip resolving examples

* Test fixtures

* newline

* Remove extra logging

* Prettier

* Update error message

* Prettier

* isWindows()

* Revert changes to .github

* Remvoe references to examples (files not present, not needed)

* Update sample tspconfig.yaml in Contoso.Management (#34114)

* [sitemanager] update tsp config (#34495)

* Create client.tsp

* reformat

* reformat

* Update client settings for releasing CarbonEmission.Net SDK (#34497)

* java, mgmt, Azure Arc site manager, client (#34527)

* Sdk config change (#34526)

* sdk config change

* typespec failures

* typespec failures

---------

Co-authored-by: deepakmaurya_microsoft <[email protected]>

* java, mgmt, MongoDB Atlas, client (#34467)

* Add PipelineForceDisabled status

* Remove PipelineForceDisabled status

* Remove ForceDisable

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Steven Kim <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: deepakmauryams <[email protected]>
Co-authored-by: deepakmaurya_microsoft <[email protected]>
Co-authored-by: SallyAnneBennett <[email protected]>
Co-authored-by: Ajay Kumar <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Jorge Rangel <[email protected]>
Co-authored-by: Jorge Rangel <[email protected]>
Co-authored-by: Daniel Jurek <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Co-authored-by: yashoswal <[email protected]>
Co-authored-by: Yash Oswal <[email protected]>
Co-authored-by: Bidisha Chakraborty <[email protected]>
Co-authored-by: Arthur Ma <[email protected]>
Co-authored-by: ChenxiJiang333 <[email protected]>
Co-authored-by: Srinivas <[email protected]>
Co-authored-by: Srinivas Alluri <[email protected]>
Co-authored-by: Pan Shao <[email protected]>
Co-authored-by: Pan Shao <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: ZhidaLiu <[email protected]>
Co-authored-by: Minh Anh <[email protected]>
Co-authored-by: Alex Chrostowski <[email protected]>
Co-authored-by: Xiong Qiao <[email protected]>
Co-authored-by: savaradh <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: XiaofeiCao <[email protected]>
Co-authored-by: jliusan <[email protected]>
Co-authored-by: Hong Li(MSFT) <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: bsomeshekar <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: steve munk <[email protected]>
Co-authored-by: Faraz Siddiqui <[email protected]>
Co-authored-by: Timothee Guerin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-Suppression ARMAutoSignedOff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.